Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect lowercase dockerfile name #59

Closed
cdrani opened this issue Apr 4, 2019 · 1 comment
Closed

detect lowercase dockerfile name #59

cdrani opened this issue Apr 4, 2019 · 1 comment

Comments

@cdrani
Copy link

cdrani commented Apr 4, 2019

Currently only detects capitalized file name:

autocmd BufRead,BufNewFile Dockerfile set ft=Dockerfile
autocmd BufRead,BufNewFile Dockerfile* set ft=Dockerfile

except for wildcards:

autocmd BufRead,BufNewFile *.dock set ft=Dockerfile
autocmd BufRead,BufNewFile *.[Dd]ockerfile set ft=Dockerfile

Is there a strict reason why it can't support lowercase filenames with no extensions? I am new to docker and curious about this.

@kwakwaversal
Copy link

Seems reasonable to accept both Dockerfile and dockerfile.

The creators of docker addressed this specifically moby/moby#10807 which inspired moby/moby#10858.

I've yet to come across the file extension .dock but that's not to say it's not a thing. I typically do Dockerfile.foo and Dockerfile.bar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants