Feature/codegen refactor #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekampf
force-pushed
the
feature/codegen_refactor
branch
from
25ad629
to
70658e1
Compare
aviv-ebates
reviewed
Dec 20, 2018
gql/utils_codegen.py
Outdated
| @@ -4,6 +4,17 @@ | |||
|
|
|||
|
|
|||
| class CodeGenerator: | |||
There was a problem hiding this comment.
This class should not be called CodeGenerator. Maybe CodeChunk.
| def block(self): | ||
| return self.Block(self) | ||
|
|
||
| def write_block(self, block_header: str, *args, **kwargs): |
There was a problem hiding this comment.
I'm also not happy about this name either.
There was a problem hiding this comment.
@aviv-ebates maybe begin_block ?
There was a problem hiding this comment.
no begin is not good because it also in charge of ending...
gql/utils_codegen.py
Outdated
| return self.gen | ||
|
|
||
| def __exit__(self, exc_type, exc_val, exc_tb): | ||
| self.gen.undent() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.