Add TypeScript typings #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pls create a new npm package for typescript :) |
|
When will this be merged? |
|
can this pr get merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds typings to allow for an easier integration in TypeScript based projects.
All types are extracted from the source files and the documentation. Here the values found in the source code take precedence. For example the type of the
changeRatinghandler is((rating, name?) => void) | nullwith a default ofnullinstead of() => {}like stated in the documentation.This also fixes #10 in TypeScript projects, because I added the corresponding property to the component, since the feature is already implemented but the propTypes lack the correspondig property whilst its default is set to
Star.