Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Podspec deployment target needs to updated #123

Closed
glm4 opened this issue Jul 14, 2023 · 6 comments · Fixed by #124
Closed

Podspec deployment target needs to updated #123

glm4 opened this issue Jul 14, 2023 · 6 comments · Fixed by #124
Assignees
@kishorepran

Comments

@glm4
Copy link
Contributor

glm4 commented Jul 14, 2023

Currently, the podspec specify the deployment target to iOS 8.0.

For other Cocoapods libraries, if you have Device as a dependency pod, your library will not lint correctly your podspec using Xcode 14.3 and up. Please refer to this issue on Cocoapods.
So far there is no way to specify custom deployment targets for dependencies with the Podspec syntax, so this should be resolved by each pod podspec.

This is not a problem if you install the dependency via SPM or directly into your project via cocoapods
@kishorepran
Copy link
Collaborator

@glm4 : will updating the pod spec to 9.0 suffice...? If yes I will raise a pr > add you for review> release a minor version. let me know thanks.

@glm4
Copy link
Contributor Author

glm4 commented Jul 15, 2023

Hi @kishorepran!
Unfortunately no 😢
Xcode 14.3 ony supports from iOS 11 and up.
It is a limitation for Device doing this update?

@kishorepran
Copy link
Collaborator

hi @glm4 . I am not sure. Will need to check. by default I want to keep the min version possible. Let me give this a try tomorrow.

@ozgur
Copy link
Contributor

ozgur commented Jul 28, 2023 •
edited

same issue for carthage as well:

/Users/ozgur/Developer/TestApp/Carthage/Checkouts/Device/Device.xcodeproj: warning: The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 11.0 to 16.4.99. (in target 'Device' from project 'Device') ** ARCHIVE FAILED **

@kishorepran kishorepran self-assigned this Jul 29, 2023
@kishorepran kishorepran mentioned this issue Jul 29, 2023
Merged
@kishorepran
Copy link
Collaborator

kishorepran commented Jul 29, 2023 •
edited

Guys can you please review my pr will merge and release version ASAP
@glm4: sorry for delay
@ozgur : Is it possible for you to check with my branch for Carthage. thanks for your support.

Edit:
🎉 Congrats
🚀 Device (3.5.0) successfully published
📅 August 1st, 13:38
🌎 https://cocoapods.org/pods/Device
👍 Tell your friends!

@glm4
Copy link
Contributor Author

glm4 commented Jul 31, 2023

@kishorepran LGTM

kishorepran added a commit that referenced this issue Aug 1, 2023
@kishorepran
set min iOS version support to iOS 11 and macOS 10.13 (#124)
5005482 
* set min iOS version support to iOS 11 and macOS 10.13

as per issue #123 update the min deployment target from iOS 8 to iOS 11 and macOS 10.10 to macOS 10.13

* Update project.pbxproj

disable automatic code signing

* Update README.md
@glm4 glm4 mentioned this issue Aug 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kishorepran kishorepran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

set min iOS version support to iOS 11 and macOS 10.13
3 participants
@ozgur @glm4 @kishorepran