Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment default values #35

Merged
merged 4 commits into from Sep 7, 2014
Merged

Comment default values #35

merged 4 commits into from Sep 7, 2014

Conversation

ping86
Copy link
Contributor

@ping86 ping86 commented Aug 13, 2014

Pull request to #34 issue

@@ -22,4 +22,11 @@
class Comment extends CommentModel
{

public function __construct()
{
$this->date = new \DateTime("0000-00-00");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line (and the following one) should be in the Model class shouldn't it ? (cc @eko )

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ping86 Yes @xavismeh is right, you must put this in the model please

@ping86
Copy link
Contributor Author

ping86 commented Sep 3, 2014

Sorry for the wait. I change the Entity & Model.

@eko
Copy link
Collaborator

eko commented Sep 7, 2014

Thank you @ping86

eko added a commit that referenced this pull request Sep 7, 2014
@eko eko merged commit eba16b2 into ekino:master Sep 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants