Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cabal-docspec #58

Merged
merged 1 commit into from Dec 30, 2020
Merged

Use cabal-docspec #58

merged 1 commit into from Dec 30, 2020

Conversation

phadej
Copy link
Contributor

@phadej phadej commented Dec 28, 2020 •
edited

Resolves #47

This PR is part of ekmett/lens#959 effort

@phadej phadej force-pushed the docspec branch 2 times, most recently from 64f681a to 00621ca Compare December 28, 2020 23:00
RyanGlScott
RyanGlScott reviewed Dec 29, 2020
View reviewed changes
cabal.haskell-ci Outdated Show resolved Hide resolved
@phadej
Copy link
Contributor Author

phadej commented Dec 29, 2020

Now cabal-doscpec is running across all GHCs. Thanks for challenging me to look closer to what doctest does. This is a lot better.

@phadej phadej changed the title WIP: Use cabal-docspec Use cabal-docspec Dec 30, 2020
@phadej phadej marked this pull request as ready for review December 30, 2020 00:39
@phadej phadej force-pushed the docspec branch 2 times, most recently from 11f3d83 to 5077455 Compare December 30, 2020 00:49
@phadej
Use cabal-docspec
264f905 
... make package build-type: Simple
@phadej
Copy link
Contributor Author

phadej commented Dec 30, 2020

After this and distributive PR are merged. I kindly asks you to make releases for:

  • comonad
  • contravariant
  • th-abstaction
  • distributive

That would resolve plenty TODOs in ekmett/lens#959 (and bust people's cabal store cache just once!)

@phadej
Copy link
Contributor Author

phadej commented Dec 30, 2020

To avoid any possible confusion, and to be explicit: I do not need lens release. That can wait.

@RyanGlScott RyanGlScott merged commit 5f43e0a into ekmett:master Dec 30, 2020
@RyanGlScott
Copy link
Collaborator

I've uploaded comonad-5.0.8 to Hackage with these changes, along with new versions of the other libraries listed in #58 (comment).

@RyanGlScott RyanGlScott mentioned this pull request Dec 30, 2020
Closed
@phadej phadej deleted the docspec branch December 30, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanGlScott RyanGlScott RyanGlScott left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove cabal-doctest dependency
2 participants
@phadej @RyanGlScott