Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better unit tests #150

Open
peterluthunder opened this issue Mar 19, 2019 · 2 comments
Open

better unit tests #150

peterluthunder opened this issue Mar 19, 2019 · 2 comments

Comments

@peterluthunder
Copy link

  1. Thx for such a great library!!

  2. I'm extending this library for my own project and was planning on writing property tests with quickcheck for my extended classes. I may write some arbitrary instances for some data types in Matrix.Linear. Any interest for me to make a PR for these instances + basic unit tests? It won't be very comprehensive but it'll be a good starting point for more property tests in the future.

@ekmett
Copy link
Owner

ekmett commented Sep 24, 2019

I don't have any objection to better tests. That said, we'd probably pull the quickcheck properties into a separate library (or as a separate sub-library once cabal 3 has wider distribution.) as historically incurring dependencies on QuickCheck for Arbitrary instances for the production version of a library is a bit of a cultural faux pas in the haskell community.

@minimapletinytools
Copy link

I made a very WIP property test package: https://github.com/pdlla/linear-tests

It's just a few tests and different Arbitrary instances for some types in linear-matrix. This is already very useful for writing property tests for things that make use of linear-matrix so I figure I'd make it available now.

(this is @peterluthunder I accidentally used my old work account when I opened this issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants