Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide context.Context based API #89

Closed
okhowang opened this issue May 27, 2021 · 3 comments · Fixed by #92
Closed

Provide context.Context based API #89

okhowang opened this issue May 27, 2021 · 3 comments · Fixed by #92

Comments

@okhowang
Copy link
Contributor

related #81
there is no way to access timeout/deadline/tracing when use many remote cache backend currently
@eko
Copy link
Owner

eko commented May 28, 2021

Hi @okhowang,

Thank you for this issue.
I had this in mind since a lot, finally took some time to do it.

This is now done in pull request: #90
A new major version has been released: https://github.com/eko/gocache/releases/tag/v2.0.0

@eko eko closed this as completed May 28, 2021
@okhowang
Copy link
Contributor Author

I notice that loadFunction has no context.Context arguments currently,
can we add it?

@eko
Copy link
Owner

eko commented May 30, 2021

@okhowang Yes you’re right, the context can be added to this function too

@okhowang okhowang mentioned this issue May 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added context to loadFunction okhowang/gocache
2 participants
@eko @okhowang