Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Your newlist function is really cool, here's how to make it better #16

Closed
Razpudding opened this issue Sep 15, 2017 · 1 comment
Closed

Comments

@Razpudding
Copy link

https://github.com/pesh12/Javascript1/blob/cc41a99136c5b32ff99305b8ad99c381651eccc5/Week3/allTogetger.js#L123

So the function already works really well. I like how you add headings to each book.
First thing that could be better is adding the lis to a list. Theyre list elements after all so adding them to the body doesnt make sense, give them an ul parent.
Second: What could be better is the variable names. instead of item1 for instance, write liElement.
Third: Try giving the newlist a parameter, and have that parameter be the list of books. That way you could also pass it another list of books and it would still work!

@ekocibar
Copy link
Owner

Thanks again.
Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants