Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not work with localized date #11

Closed
psi-4ward opened this issue Jan 2, 2019 · 4 comments
Closed

does not work with localized date #11

psi-4ward opened this issue Jan 2, 2019 · 4 comments
Labels
good first issue Good for newcomers

Comments

@psi-4ward
Copy link
Contributor

  locales: {
    "/": {
      lang: "de-DE"
    }
  },

sets page.lastUpdated to dates like:

  • 2.1.2019, 12:17:10
  • 28.12.2018, 03:29:42

which can't be use in new Date()

@ekoeryanto
Copy link
Owner

Hi, thanks for the issue.
Can you please, create the PR to fix in here?

@ekoeryanto
Copy link
Owner

I think it solved with dateFormatter option in v2.3.0

@psi-4ward
Copy link
Contributor Author

It's not very comfortable that we have to implement our own reverse-dete-formatter, especially if we have more than one date (ie in multilang websites). I still would prefer a the lastUpdateTstamp solution. What do you think?

@ekoeryanto
Copy link
Owner

@psi-4ward, i agree with you.
please finish the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants