Page break does not seem to increase document height

[williambowsher]

When I use the page break functionality, they are placed exactly where I want them, but the document gets cropped at the bottom by the amount of space added by the page breaks.

Unfortunately this is resulting in an approval element being omitted from the pdf.

form_nopagebreaks.pdf
form_pagebreaks.pdf

Below is the code we use to save the html element as a PDF

`viewModel.SaveHtml2Pdf = function() {
var element = $('div.data-entry-form:first');
var source = element[0];

var username = $('a.user-name:first').text().replace(/\s+/g, '').replace(/"/g, '');
var friendlyForm = friendlyFormName(viewModel.FormType());
var formid = viewModel.FormData.Id();

html2pdf(source,{
    margin: 20,
    filename: 'complianceform.pdf',
    image: { type: 'jpeg', quality: 1 },
    html2canvas: { dpi: 300, letterRendering: true },
    jsPDF: { unit: 'mm', format: 'A4', orientation: 'portrait' },
    jsPDFProperties: {
        title: 'CAFE Compliance Form',
        subject: friendlyForm + ' - ' + formid,
        author: username,
        keywords: 'CAFE, cafe, compliance, ' + friendlyForm,
        creator: 'CAFE'
    },
    title: 'CAFE - ' + friendlyForm + ' - ' + username
});

};`

[williambowsher]

Think this issue is not related to the html2pdf code but related to the html2canvas cropping the image.

[eKoopmans]

Hi @scriptmonkey69, sorry again for the delay. This looks like the offscreen rendering bug. Try the version of html2canvas in the /vendor/ directory of this package, it might resolve your problem. More info here.

[williambowsher]

Worked like a charm thank you. Will be deploying fix to production this week. Keep up the good work.

…

On 17 Sep 2017 1:08 p.m., "Erik Koopmans" ***@***.***> wrote: Hi @scriptmonkey69 <https://github.com/scriptmonkey69>, sorry again for the delay. This looks like the offscreen rendering bug <niklasvh/html2canvas#1083>. Try the version of html2canvas in the /vendor/ directory of this package, it might resolve your problem. More info here <#2 (comment)>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#31 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AVAgZ-Px7FYkBzelKhrhrs1RNXqBYsHHks5sjP2QgaJpZM4PQ4iZ> .

[eKoopmans]

Great, happy to help! Is it safe to close the issue?

[williambowsher]

Yep

…

On 19 Sep 2017 3:50 p.m., "Erik Koopmans" ***@***.***> wrote: Great, happy to help! Is it safe to close the issue? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#31 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AVAgZybrKSWRG3hN8MXLYB210mEw4FNiks5sj8augaJpZM4PQ4iZ> .

[jCabigting]

Hi @eKoopmans, I'm having this issue but for some reason I can't find the /vendor/ folder that you're pointing to. Has it been removed? And is there a permanent fix for this issue?

[eKoopmans]

Hi @jCabigting, sorry for the long delay.

There's no longer a /vendor/ directory, instead my suggestion would be to make sure you're using the "bundled" version of the package, html2pdf.bundle.js. That has the latest version of html2canvas and jsPDF bundled in. The issue described above had to do with an older version of html2canvas that should be resolved now.