Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eksctl enable profile should check for Flux's existence #1534

Closed
marccarre opened this issue Nov 7, 2019 · 3 comments
Closed

eksctl enable profile should check for Flux's existence #1534

marccarre opened this issue Nov 7, 2019 · 3 comments
Labels
area/gitops gitops related issues kind/bug kind/feature New feature or request priority/backlog Not staffed at the moment. Help wanted. priority/important-longterm Important over the long term, but may not be currently staffed and/or may require multiple releases

Comments

@marccarre
Copy link
Contributor

marccarre commented Nov 7, 2019

Why do you want this feature?

From #1509 onwards, enable repo installs Flux, and enable profile installs the components from the specified quickstart profile. However, should an user only run enable profile, nothing would get deployed.

What feature/behavior/change do you want?

  1. Check for Flux's existence in:
    1. the Kubernetes cluster?
    2. the Git repository?
  2. Either:
    1. error out mentioning that enable repo should be run first?
    2. print a warning mentioning that Flux couldn't be detected, and suggest that the user may want to run the enable repo command first?
    3. install Flux directly?
@marccarre marccarre added kind/feature New feature or request kind/bug area/gitops gitops related issues labels Nov 7, 2019
@martina-if
Copy link
Contributor

Is there a usecase where a user would want to prepare a repo first, and then add flux? Because in that case it would be ok to not error.

To me, it makes sense that enable profile doesn't know anything about flux and just limits its responsibility to taking manifest templates from one repo and place them in another repo. It doesn't touch the cluster at all to do that. This also makes it possible to move this functionality somewhere else if we want to in the future.

@martina-if martina-if added the priority/important-longterm Important over the long term, but may not be currently staffed and/or may require multiple releases label Apr 14, 2020
@martina-if martina-if added the priority/backlog Not staffed at the moment. Help wanted. label Sep 9, 2020
@Callisto13
Copy link
Contributor

I agree with martina's point, but also see the value in letting users know what it will take to have that repo "work" in their cluster.

Point 2.ii seems to be the right move.

print a warning mentioning that Flux couldn't be detected, and suggest that the user may want to run the enable repo command first?

We should let the enable profile command succeed and print a clear warning about enable repo

@Himangini
Copy link
Collaborator

#2963 This command is deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gitops gitops related issues kind/bug kind/feature New feature or request priority/backlog Not staffed at the moment. Help wanted. priority/important-longterm Important over the long term, but may not be currently staffed and/or may require multiple releases
Projects
None yet
Development

No branches or pull requests

4 participants