Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SourceSecurityGroupIDs doesn't work in unmanaged node group, but this is not mentioned in the config schema. #2366

Closed
readybuilderone opened this issue Jun 24, 2020 · 4 comments · Fixed by #3254
Assignees
Labels
area/general-cli kind/docs User documentation kind/feature New feature or request priority/backlog Not staffed at the moment. Help wanted.

Comments

@readybuilderone
Copy link

readybuilderone commented Jun 24, 2020

In the config file schema(https://eksctl.io/usage/schema/) I found the SourceSecurityGroupIDs cloud be used for both managed node group and unmanaged nodegroup.

However, when I tried to create unmanaged nodegroup with SourceSecurityGroupIDs, I run in to the error:
"Error: nodeGroups[0].sourceSecurityGroupIds is not supported for unmanaged nodegroups"

For double confirm, I generated the schema using command: "eksctl utils schema" and found the SourceSecurityGroupIDs cloud be used for both managed node group and unmanaged nodegroup as well.

I did some research and found the validation in this file(https://github.com/weaveworks/eksctl/blob/a7fc5f6e8adc9e5581d7d8d128c7ed806675bb0f/pkg/apis/eksctl.io/v1alpha5/validation.go):

	if ng.SSH != nil {
		if err := validateNodeGroupSSH(ng.SSH); err != nil {
			return err
		}
		if len(ng.SSH.SourceSecurityGroupIDs) > 0 {
			return fmt.Errorf("%s.sourceSecurityGroupIds is not supported for unmanaged nodegroups", path)
		}
	}

So I think the config schema should be wrong, the sourceSecurityGroupIds should be marked, it is not supported for unmanaged nodegroups.

@michaelbeaumont michaelbeaumont self-assigned this Jun 24, 2020
@martina-if martina-if added area/general-cli priority/backlog Not staffed at the moment. Help wanted. labels Jun 24, 2020
@michaelbeaumont michaelbeaumont added kind/docs User documentation and removed kind/bug labels Jun 25, 2020
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@zmarouf
Copy link

zmarouf commented Feb 10, 2021

Bump. What's the actual expected state? Will it be supported or should I just use a local/shared/extra attached security group for this on unmanaged nodegroups?
Thank you in advance for clearing this up! :)

@cPu1
Copy link
Collaborator

cPu1 commented Feb 11, 2021

Bump. What's the actual expected state? Will it be supported or should I just use a local/shared/extra attached security group for this on unmanaged nodegroups?
Thank you in advance for clearing this up! :)

We have decided to add support for sourceSecurityGroupIds for unmanaged nodegroups. There's no reason not to support it. This feature can be tracked in this PR: #3254

@cPu1 cPu1 added the kind/feature New feature or request label Feb 11, 2021
@cPu1
Copy link
Collaborator

cPu1 commented Feb 11, 2021

The PR has been merged and it'll be out in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/general-cli kind/docs User documentation kind/feature New feature or request priority/backlog Not staffed at the moment. Help wanted.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants