Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eksctl set/unset labels support for non-eksctl created cluster #2810

Closed
aclevername opened this issue Nov 10, 2020 · 4 comments · Fixed by #3168
Closed

eksctl set/unset labels support for non-eksctl created cluster #2810

aclevername opened this issue Nov 10, 2020 · 4 comments · Fixed by #3168
Assignees
@Callisto13
Labels
area/general-cli good first issue Good for newcomers kind/feature New feature or request

Comments

@aclevername
Copy link
Contributor

Why do you want this feature?
I want to be able to use eksctl to set labels on clusters/nodegroups that were not created by eksctl

What feature/behavior/change do you want?
eksctl set/unset label support for non-eksctl created clusters/nodegroup

Related issue #2174 (comment)
@aclevername aclevername added the kind/feature New feature or request label Nov 10, 2020
@aclevername aclevername mentioned this issue Nov 10, 2020
Closed
@aclevername aclevername added the good first issue Good for newcomers label Nov 10, 2020
@Callisto13 Callisto13 self-assigned this Jan 21, 2021
@Callisto13
Copy link
Contributor

is getting labels also a thing here?

@aclevername
Copy link
Contributor Author

is getting labels also a thing here?

I did not spot that! Yes please 😄

@aclevername aclevername mentioned this issue Jan 26, 2021
Closed
@aclevername
Copy link
Contributor Author

@Callisto13 could you add integration test coverage for this as part of this work?

@Callisto13
Copy link
Contributor

Hmm alright but it'll cost you.

@Callisto13 Callisto13 linked a pull request Jan 28, 2021 that will close this issue
Set/Unset/Get labels on unowned nodegroups #3168
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Callisto13 Callisto13

Labels
area/general-cli good first issue Good for newcomers kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set/Unset/Get labels on unowned nodegroups Callisto13/eksctl
2 participants
@Callisto13 @aclevername