Possibility to set preBootstrapCommands when using custom ami with managed nodegroups

[kishoregv]

What feature/behavior/change do you want?

When pinning AMI for a managed nodegroup, currently eksctl ignores preBootstrapCommands. It would nice to have preBoostrapCommands.

AWS blog talks about the workflow with eksctl, but eksctl does not respect preBootstrapCommands when using custom AMI.

Why do you want this feature?

This will allow us to do additional configuration before bootstrapping.

[niroowns]

Is this a bug? eksctl docs/examples state this is possible:

https://github.com/weaveworks/eksctl/blob/51b66753f000e0c6881c0883b55524ab27d09754/examples/15-managed-nodes.yaml#L47

https://eksctl.io/usage/schema/#managedNodeGroups-preBootstrapCommands

Tracking the code base, it appears that makeCustomAMIUserData (https://github.com/weaveworks/eksctl/blob/main/pkg/nodebootstrap/managed_al2.go#L38) only respects the OverrideBootstrapCommand function (not preBootstrap):
https://github.com/weaveworks/eksctl/blob/main/pkg/nodebootstrap/managed_al2.go#L86-L90

[tanvp112]

the example from aws blog is not valid; overrideBootstrapCommand is not a sub-key of preBootstrapCommands.

[cPu1]

Is this a bug? eksctl docs/examples state this is possible:

https://github.com/weaveworks/eksctl/blob/51b66753f000e0c6881c0883b55524ab27d09754/examples/15-managed-nodes.yaml#L47

https://eksctl.io/usage/schema/#managedNodeGroups-preBootstrapCommands

Tracking the code base, it appears that makeCustomAMIUserData (https://github.com/weaveworks/eksctl/blob/main/pkg/nodebootstrap/managed_al2.go#L38) only respects the OverrideBootstrapCommand function (not preBootstrap):
https://github.com/weaveworks/eksctl/blob/main/pkg/nodebootstrap/managed_al2.go#L86-L90

You're right, preBootstrapCommands is being ignored when a custom AMI is supplied. This is a bug and we're going to look into it.

@kishoregv, additionally, as @tanvp112 noted, the example in the AWS blog post is incorrect, overrideBootstrapCommand is a top-level field of nodegroup.

[kishoregv]

@kishoregv, additionally, as @tanvp112 noted, the example in the AWS blog post is incorrect, overrideBootstrapCommand is a top-level field of nodegroup.

Agree, did not go with it literally I have considered the indentation issue in my test. I should have already called it out in my issue report.
Thanks