Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Automatically propagate ASG labels and taints for managed nodegroups. #7540

Closed
rwilson-release opened this issue Feb 8, 2024 · 6 comments
Labels

Comments

@rwilson-release
Copy link

What feature/behavior/change do you want?

Currently, ASG tags are propagated automatically for managed and unmanaged nodegroups via the propagateASGTags field.

However, taints and tolerations are NOT automatically propagated for managed nodegroups. See the massive confusions in #4965 #5420 and finally documentation "fix" in #5574.

Unfortunately, the live site documentation does not appear to be updated, see (retrieved 2024-02-08)
image

There are two requests:

  1. Allow automatic propagation of taints and labels via the propagateASGTags field for managed nodegroups (to match the behaviour of unmanaged nodegroups).
  2. Reflect the current state of docs in the live site since they seem to be a few years out of date with the repository in this case.

Why do you want this feature?

Adding a workaround to generate the labels and taints for the tags just because we use managed nodegroups as opposed to unmanaged is needless and frustrating since the live site documentation says it does what we want.

@rwilson-release rwilson-release added the kind/feature New feature or request label Feb 8, 2024
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Hello rwilson-release 👋 Thank you for opening an issue in eksctl project. The team will review the issue and aim to respond within 1-5 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

@rwilson-release
Copy link
Author

See #5002

@yuxiang-zhang
Copy link
Member

Looks like the docs were updated again with #5678

@rwilson-release
Copy link
Author

Oh dear then it seems this is a bug that propagateASGTags appears not to work properly for tags, taints and lables in at least version 0.167.0. Will need to write up a bug then.

@rwilson-release
Copy link
Author

My view of the docs viz the repository were skewed because I was viewing the repository as of an old date, my apologies. I will need to document the behaviour I'm seeing.

@rwilson-release
Copy link
Author

I'll reopen with a bug report on tags/taints/labels not being updated.

@rwilson-release rwilson-release closed this as not planned Won't fix, can't repro, duplicate, stale Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants