Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d-pad swipe up to ignite saber? #1

Open
micahstubbs opened this issue Dec 27, 2018 · 5 comments
Open

d-pad swipe up to ignite saber? #1

micahstubbs opened this issue Dec 27, 2018 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@micahstubbs
Copy link

d-pad swipe up to ignite saber?

it might be nice to double-map the ignite saber action to both the trigger press and the directional pad swipe up gesture.

I've used the directional pad swipe up gesture for a similar laser sword ignite action in some other Vive experience (either Trials on Tatooine or Lightblade, don't recall). It could be nice to add that control as well to be friendly to player who already have that muscle memory from those experiences.

@NathanWolf
Copy link
Contributor

Nice idea! I was thinking of using the touchpad for changing saber style/color if/when I have different sabers, but that's probably better left in a menu anyway.

@NathanWolf
Copy link
Contributor

I pushed a change that implements this. I'll make a new release with it soonish, but I'd like to get the environment detection working first.

Unfortunately I've realized this is a little problematic since the controller currently uses transform updates (e.g. teleportation) to move the saber around, which doesn't really get along well with collision detection.

Anyway, thanks for the suggestion!

@NathanWolf NathanWolf self-assigned this Dec 30, 2018
@NathanWolf NathanWolf added the enhancement New feature or request label Dec 30, 2018
@micahstubbs
Copy link
Author

interesting. curious, how do the transform updates (e.g. teleportation) interfere with collision detection?

@NathanWolf
Copy link
Contributor

My (somewhat limited) understanding is that the physics system only works with impulses and velocities. Which makes sense, really. If you teleport an object from one side of a wall to the other side, it's not going to know you passed through it.

Similarly, if I teleport an object into another object it won't detect the collision.

I decided to just remove the collider on the saber for now, though I may have to put it back later if I add projectiles to hit. For now I'm doing collision detection myself with ray/box casts.

I have some sparks flying out of things you slice, which feels pretty nice. I'd like to make some decals that stay around to look like it's sliced through, if I can get that working fairly well I want to fix the icon then I'll release a new version.

@micahstubbs
Copy link
Author

ah interesting, thanks for explaining!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants