-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INCOMPATIBILITY WITH FUTURE HA Core 2025.1 #221
Comments
Thanks. Seeing the same |
thank you @kramttocs and @elad-bar for offering a fix. I'm running v1.0.16 (installed today) of this plugin, and i still see both errors:
e.g.
|
Hi @morikplay , |
@morikplay well, the fix (PR) is not merged yet. You need to run the code from #222 |
Ah. I now see that the commit has yet to be merged. I can try to manually copy over the changed files. Could the copy-over work without HA restart? |
Best would be to download the entire code from the PR as a zip and then copy-replace all files (without trying to figure out what files were changed). |
@olympia much obliged. Took your advice. Replaced line#14 and such use new code:
Restarted haos. Still seeing entity errors:
|
Yes, same for me, that's what I meant above. There was another issue with "SUPPORT_STREAM" being used by Blue Iris as described in the original post of this issue. That has been fixed/ gone using the code from the PR, but we still see the Entity camera.xxx issues being logged. |
Ah. Sorry, slow learner over here. Now, I'm all caught up. If i understand the
to something like:
|
elad-bar already took care of that part of the code so it conforms now.
to
Or it may not like the use of _supported_features at all in the init method... |
Non of the two (@morikplay's and @kramttocs') above proposed change fixes the camera.xxx supported features warning at my side. |
Please try the code from #223 |
@kramttocs camera.xxx supported features warnings have been disappeared with this PR :) |
elad-bar may have a better suggestion than the code change I made but at least we know what will make HA happy :) |
Thank you @olympia and @kramttocs. Supported features documentation said that the feature set is now a bitwise OR. Hence |
For me now Supported features returns a big 0 individually. I am far for being an expert, I am just a user and can only test things out. :) |
Hey @morikplay - can you elaborate on your concern with the individual elements? |
@olympia You don't have 'Support stream component (Requires restart)' checked in the Configure options, right? |
Indeed. Camera's supported features has two defined values:
Each of which corresponds to certain methods eg Of course this is my first time looking into the innards of HA. So, please take anything I say with a grain of salt. Thank you for taking my comments into consideration. |
Correct, I have this unchecked. Shall I turn this on now for testing or in general? |
@morikplay And if you are curious you can see another implementation here: https://github.com/home-assistant/core/blob/dev/homeassistant/components/netatmo/camera.py Sorry, I am still not understanding what your concern with the fixes are - and I am asking in the "if there's a better way, let's do it that way" attitude. As far as I can tell from the doc, setting them this way is equivalent to how they are showing it. @olympia Good - was hoping you didn't have it checked and it was still showing 0. As for turning it on, that's up to you if you want to use the stream component. I don't actually show any camera feeds in HA so am not a good person to ask 😁 |
Thank you for the reference @kramttocs. I certainly wasn't questioning either your judgement or implementation 😃. I will defer the eventual solution to your wisdom. Thank you for being open to other ways of fixing the issue. Looking at the reference lines 180-187 I do see the use of bit wise or I do have steaming enabled in my setup. I'm happy to study it further if you think there's merit in it. |
@morikplay Oh please question away! There are a lot of things I don't fully have my head wrapped around in this custom component so am often just standing on the shoulders of giants. I follow now - yes, if we were using both of the features, we would That's good that you have streaming enabled - please look at the camera in Developer Tools to ensure the support_features shows the Stream value and then keep us updated if you see anything odd with the camera streams. |
Thank you @kramttocs. Supported features has a big fat 0 despite streaming enabled :( |
Thanks! I'll look into it. |
Is there any progress in addressing this issue? I'm really maried to BI and HA for many reasons. P.S. You folks that have the know how to fix such things is realy appreciated. |
I have a pr for it - just need to merge it and push a release |
I don't have a clue how this all works or how long things take, but any update on this? Was just checking logs and saw this again and wondered if there was any news. Either way thank you very much for keeping this integration working! |
Sorry, it won't take long - I just need to find the time to do it. I'll make a note to try to work on it this weekend. |
No pressure, all good. It should still be good to 2025 😁 Was just wondering! |
Go ahead and give it a go - v1.0.18 is out there. Admittedly I didn't really test my latest changes but they are just around logging so pretty safe. The other change in there were tested previously in this thread so those shouldn't cause any grief. Let me know how it goes. |
Awesome, rebooted and only error left for me is HACS accessing front-end. Nothing else! |
Well. This solved this error. Thank you a bunch. |
I'm using Blue Iris integration to show cameras.
I found this in the log:
Logger: homeassistant.components.camera
Source: helpers/deprecation.py:204
Integration: Camera (documentation, issues)
First occurred: 8:56:53 AM (4 occurrences)
Last logged: 8:57:00 AM
SUPPORT_STREAM was used from blueiris, this is a deprecated constant which will be removed in HA Core 2025.1. Use CameraEntityFeature.STREAM instead, please create a bug report at https://github.com/elad-bar/ha-blueiris/issues
SUPPORT_STREAM was used from dahua, this is a deprecated constant which will be removed in HA Core 2025.1. Use CameraEntityFeature.STREAM instead, please create a bug report at https://github.com/rroller/dahua/issues
Logger: homeassistant.helpers.entity
Source: helpers/entity.py:1520
First occurred: 8:56:55 AM (10 occurrences)
Last logged: 8:57:00 AM
Entity camera.house_num_4 (<class 'custom_components.blueiris.camera.BlueIrisCamera'>) is using deprecated supported features values which will be removed in HA Core 2025.1. Instead it should use <CameraEntityFeature: 0>, please create a bug report at https://github.com/elad-bar/ha-blueiris/issues and reference https://developers.home-assistant.io/blog/2023/12/28/support-feature-magic-numbers-deprecation
Entity camera.house_num_5 (<class 'custom_components.blueiris.camera.BlueIrisCamera'>) is using deprecated supported features values which will be removed in HA Core 2025.1. Instead it should use <CameraEntityFeature: 0>, please create a bug report at https://github.com/elad-bar/ha-blueiris/issues and reference https://developers.home-assistant.io/blog/2023/12/28/support-feature-magic-numbers-deprecation
Entity camera.house_front_door (<class 'custom_components.blueiris.camera.BlueIrisCamera'>) is using deprecated supported features values which will be removed in HA Core 2025.1. Instead it should use <CameraEntityFeature: 0>, please create a bug report at https://github.com/elad-bar/ha-blueiris/issues and reference https://developers.home-assistant.io/blog/2023/12/28/support-feature-magic-numbers-deprecation
Entity camera.front_doorbell_main (<class 'custom_components.dahua.camera.DahuaCamera'>) is using deprecated supported features values which will be removed in HA Core 2025.1. Instead it should use <CameraEntityFeature.STREAM: 2>, please create a bug report at https://github.com/rroller/dahua/issues and reference https://developers.home-assistant.io/blog/2023/12/28/support-feature-magic-numbers-deprecation
Entity camera.front_doorbell_sub (<class 'custom_components.dahua.camera.DahuaCamera'>) is using deprecated supported features values which will be removed in HA Core 2025.1. Instead it should use <CameraEntityFeature.STREAM: 2>, please create a bug report at https://github.com/rroller/dahua/issues and reference https://developers.home-assistant.io/blog/2023/12/28/support-feature-magic-numbers-deprecation
The text was updated successfully, but these errors were encountered: