Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/dev/isa/seagate.c is not MI #13

Closed
elad opened this issue Jun 18, 2014 · 1 comment
Closed

sys/dev/isa/seagate.c is not MI #13

elad opened this issue Jun 18, 2014 · 1 comment
Labels
has fix low hanging fruit

Comments

@elad
Copy link
Owner

elad commented Jun 18, 2014

Metadata

  • Number: 18887
  • Originator: Perry E. Metzger <perry@piermont.com>
  • Arrived: Sat Nov 02 02:15:00 +0000 2002
  • Last modified:
  • Environment: System: NetBSD alchemist 1.6H NetBSD 1.6H (ALCHEMIST) #0: Thu Oct 3 19:36:25 EDT 2002 perry@alchemist:/usr/src/sys/arch/i386/compile/ALCHEMIST i386 Architecture: i386 Machine: i386

Description


    sys/dev/isa/seagate.c contains x86 asm in it. This would tend
to make one believe it is not, in fact, MI code.

How to repeat


    fgrep asm /usr/src/sys/dev/isa/seagate.c

Fix


    Either make it use right abstraction or move the thing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
has fix low hanging fruit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elad