-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No way to opt-out of SimplifyTopology when creating Manifold from MeshGL #679
Comments
I'm thinking this might be another case where we should disable simplify by default, since importing Meshes doesn't inherently create redundant faces, and it's more likely the existing mesh structure is intentional by the user. |
On a semi related note, is it possible to tell which triangles are touching the last boolean op surface? I wonder if it makes sense to apply simplification only to affected triangles and leave the rest untouched. |
I found a work-around - assigning a unique
|
I do think that this is desirable, and in general we should probably not collapse triangles that are not created due to boolean operations. @elalish what do you think? |
As a performance thing I do think it may be useful to only look for edge collapses among the newly-created verts in a Boolean. I think that shouldn't even be too hard, since we start by putting all the new verts at the end of the list. I think assigning unique face IDs is the right approach to the OP issue though. Otherwise the behavior would change when exporting and importing a mesh in the middle of several Boolean ops. |
Not sure what you mean by the behavior would change when exporting and importing a mesh in the middle of several boolean ops. I think the mesh is still simplified at the end of each boolean operations (before export), and ideally importing the mesh should not require any further simplification? Currently we do have different behavior if we export and import the mesh again, because our simplification is only best-effort and applying it multiple times can have different results. |
So I'm stuck again getting my verts and triangles auto-deleted before I can use them.
This time I prototyped a
refine_to_length()
function in python using MeshGL interface - if the longest edge is >threshold, cut it in half.But when I import it into a
Manifold
in order to use for CSG and Warp, it forcibly simplifies backThe text was updated successfully, but these errors were encountered: