Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues and improvements for search functionality #389

Closed
9 of 12 tasks
LukasKalbertodt opened this issue Mar 28, 2022 · 1 comment
Closed
9 of 12 tasks

Issues and improvements for search functionality #389

LukasKalbertodt opened this issue Mar 28, 2022 · 1 comment
Labels
area:backend Everything backend related area:design Issues specifically about the broader design of the site area:frontend Everything frontend related area:search Related to Tobira's search kind:improvement

Comments

@LukasKalbertodt
Copy link
Member

LukasKalbertodt commented Mar 28, 2022

The backend site of the search story is pretty good, thanks to #383. But, especially in the frontend, there is a lot to do. In random order:

  • Probably switch to instant-search.js no
  • Use history API in a better way: don't add an entry for every key stroke
  • Highlight matches (i.e. somehow highlight the parts of data that matched the query) -> Highlight matches in main search results #1065
  • Pagination (?) -> Add pagination or infinite scrolling to main search #1067
  • Generally have a better design
  • Add button to "get back" to the previous page. Also do that when ESC was pressed
    • Emptying the search input should do the same -> actually it shouldn't
  • Update search input field correctly when navigating via browser history stack
  • Make easier to navigate with keyboard (e.g. arrow keys?) -> Make it possible to select search results with arrow keys #1066
  • Detect when index is not ready to be searched and display a friendly message
  • Deal with the index not existing at all (or some other random error) in a better way
  • Fix thumbnail always assuming it's a video (in case thumbnail is missing)
@LukasKalbertodt
Copy link
Member Author

All remaining points have separate issues now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:backend Everything backend related area:design Issues specifically about the broader design of the site area:frontend Everything frontend related area:search Related to Tobira's search kind:improvement
Projects
None yet
Development

No branches or pull requests

1 participant