Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include non-400-like errors in ApiError #266

Closed
KodrAus opened this issue Oct 19, 2017 · 1 comment
Closed

Only include non-400-like errors in ApiError #266

KodrAus opened this issue Oct 19, 2017 · 1 comment

Comments

@KodrAus
Copy link
Member

KodrAus commented Oct 19, 2017

I don't think there's a lot of value including errors like ActionRequestValidation or Parsing in ApiError. It's really meant to be a structure that you can easily programmatically match on and respond to. But there isn't really much you can do with parsing errors.

We have this distinction between 'errors you can deal with' and errors you can log and fail with' in elastic`, so we should do the same here and capture other errors from the API elsewhere.

@KodrAus
Copy link
Member Author

KodrAus commented Oct 20, 2017

A bit of a papercut with the API response as it is is that it doesn't capture backtraces like client errors. I want the error to be easily matchable in a result, but this is kind of unfortunate.

@KodrAus KodrAus modified the milestones: Future, 0.21.x Nov 28, 2017
@KodrAus KodrAus closed this as completed Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant