-
Notifications
You must be signed in to change notification settings - Fork 855
Advanced Cluster Management Features #41
Comments
I would indeed suggest splitting management features into an extra role or even playbook. I have in the past usually created specific playbooks for a restart and then called that from a shell script to facilitate usage. I have pushed my rolling restart script to https://github.com/opencore/es_rollingrestart please feel free to reuse anything that might be useful. |
@gingerwizard I created a similar 1.x rolling restart in the past, adding it to the task directory of the role. You could conditionally use I wouldn't mind rewriting a rolling restart for 2.x, and adding in more protection (check minimum_master_nodes before running, fail if cluster ever goes red, etc). I hate the ansible uri module, but I didn't want to spend time to write it as a plugin or module. |
@jpcarey i think we should provide a separate role to do this. Anything in this role needs to be tested. Testing the functionality above will be tricky i suspect and add a maintenance cost that is likely to be unsustainable moving forward. This is also not supported in the puppet module - we are trying to aim for consistent behaviour here. |
I'm +1 for a dedicated role for these tasks |
+1 for separating. Shoving too much stuff into a single role is a bad anti-pattern in ansible and ansible-galaxy. Makes re-usability take a dive. |
@gingerwizard @jpcarey I think this duplicate with #126? |
yes duplicate and agreed this will not be added. Thanks all. |
Proposal to support:
Some of the above could already be achieved. It may not be appropriate to include this functionality in the default role - we may wish to create a separate management role.
To be discussed.
The text was updated successfully, but these errors were encountered: