We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This is more pressuring for writing tests.
Currently code like this does not unsubscribe the agent from receiving events and creating spans:
using (agent.Subscribe(new HttpDiagnosticsSubscriber())) { //do stuff } //we should not be subscribed here, but we are.
Therefore subsequent tests that assume the HttpDiagnosticsSubscriber is not registered will fail.
HttpDiagnosticsSubscriber
The text was updated successfully, but these errors were encountered:
The root cause was in DiagnosticInitializer.cs:
public void OnNext(DiagnosticListener value) { foreach (var listener in _listeners) { if (value.Name == listener.Name) value.Subscribe(listener); } }
value.Subscribe returns IDisposable which wasn't disposed. Fix is on the way.
value.Subscribe
IDisposable
Sorry, something went wrong.
Fixed by #75
gregkalapos
No branches or pull requests
This is more pressuring for writing tests.
Currently code like this does not unsubscribe the agent from receiving events and creating spans:
Therefore subsequent tests that assume the
HttpDiagnosticsSubscriber
is not registered will fail.The text was updated successfully, but these errors were encountered: