-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System.NullReferenceException when using Oracle #791
Comments
After update to version 1.4.0 the problem was solved |
@fernandolamp Could you please double check if indeed 1.4.0 resolves your issue? While we did include a fix (#749) for another issue (#746) in DB connection string parser I am not sure that fix could have done anything to resolve your issue. |
@SergeyKleyman and @gregkalapos the problem are occurring in .net core 2.2 with oracle yet, can you check again? i'm using the last version of the package. |
@Cesaragsilva could you give us the logs? Especially the callstack would be interesting. Given that the code changed in this area I expect a different callstack - but let's see... |
Please correct me if I am wrong - the fix (#795) is not included in the latest (which is at the moment 1.4.0) release. |
😱 Yes, you are right - thanks for pointing this out! #795 was merged after Ok, so, now it makes sense - @Cesaragsilva this will be in the next release which will be out very soon. Sorry about the confusion. Thanks @SergeyKleyman. |
@gregkalapos and @SergeyKleyman Thank you for check it. I'm await the next version eagerly |
Describe the bug
Hi guys,
I am using oracle with devart provider and my string connection is:
Data Source=(DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST=172.21.25.186)(PORT=1521))(CONNECT_DATA=(SERVICE_NAME=ORCLCDB)));User Id=SAJDDL; Direct=True;
When I try to get data from database, elastic apm throws a exception:
The problem happen in this method:
Below I try explain why this happened:
Debuging:
In DbSpanCommon.cs:
internal Destination GetDestination
My string connection:
DbConnectionStringParser.cs:
When try to extract destination, I noticed that the value of "key/value" pair is null:
The key is found but destination is null, and when he try to access
destination.Port.HasValue
:The exception is thrown.
To Reproduce
Steps to reproduce the behavior:
Configure oracle string connection like this: Data Source=(DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST=172.21.25.186)(PORT=1521))(CONNECT_DATA=(SERVICE_NAME=ORCLCDB)));User Id=SAJDDL; Direct=True;
Try to retrieve value from database
Expected behavior
Find database destination and don´t throw NullPointReference exception
Thank you in advance, elastic apm is awesome!
The text was updated successfully, but these errors were encountered: