New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jedis 4 support? #2616
Comments
Thanks for reporting! |
Thanks @eyalkoren! I've deployed this to our test cluster and it seems to be working well - Redis time is now shown properly in the timeline with Jedis 4 |
Awesome, thanks for the feedback! Please try it with as many scenarios as possible on your test cluster. If all looks good and you are willing to proceed with a snapshot, please try in staging or even in a limited part of a production cluster as well. Once we release, you are very likely to be our first user for it, so the more verification you make, the more confident you can be with the formal release 🙂
Apart from span times within the trace waterfall graphs, your Redis should now be also visible on the service map and dependencies as well. Please check that other datastore functionalities also work as expected. Looking forward for your feedback as an indication whether additional work is required at this point. |
Thanks. Our Jedis 4 upgrade is actually dependant on a bigger refactoring of our Redis use that needs to go out first, so it'll be a little while before I'll be able to do more extensive testing of this. I'll keep you informed |
What I did in #2626 is change the way we instrument Jedis for all versions, so that it is simpler and also more suitable for Jedis 4. |
Version 1.31.0 has been released with Jedis 4.x support. |
I tried upgrading my application to Jedis v4 and lost all Redis time from my application traces
Which makes sense, as according to https://www.elastic.co/guide/en/apm/agent/java/current/supported-technologies-details.html#supported-databases APM only supports up to Jedis 3.x
Are there any plans to support Jedis 4? It was first released back in December, and in the release notes for 3.8.0 they declare that as the last release on the 3.x line, so it will not be getting updates any more
The text was updated successfully, but these errors were encountered: