Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jedis 4 support? #2616

Closed
spmason opened this issue May 4, 2022 · 6 comments · Fixed by #2626
Closed

Jedis 4 support? #2616

spmason opened this issue May 4, 2022 · 6 comments · Fixed by #2626
Labels
agent-java community Issues and PRs created by the community triage

Comments

@spmason
Copy link

spmason commented May 4, 2022

I tried upgrading my application to Jedis v4 and lost all Redis time from my application traces

Which makes sense, as according to https://www.elastic.co/guide/en/apm/agent/java/current/supported-technologies-details.html#supported-databases APM only supports up to Jedis 3.x

Are there any plans to support Jedis 4? It was first released back in December, and in the release notes for 3.8.0 they declare that as the last release on the 3.x line, so it will not be getting updates any more

@github-actions github-actions bot added agent-java community Issues and PRs created by the community triage labels May 4, 2022
@eyalkoren eyalkoren mentioned this issue May 10, 2022
9 tasks
@eyalkoren
Copy link
Contributor

Thanks for reporting!
I tried something in #2626. Please try this agent snapshot and let us know if it works for you.

@spmason
Copy link
Author

spmason commented May 10, 2022

Thanks @eyalkoren! I've deployed this to our test cluster and it seems to be working well - Redis time is now shown properly in the timeline with Jedis 4

@eyalkoren
Copy link
Contributor

Awesome, thanks for the feedback!

Please try it with as many scenarios as possible on your test cluster. If all looks good and you are willing to proceed with a snapshot, please try in staging or even in a limited part of a production cluster as well. Once we release, you are very likely to be our first user for it, so the more verification you make, the more confident you can be with the formal release 🙂

Redis time is now shown properly in the timeline with Jedis 4

Apart from span times within the trace waterfall graphs, your Redis should now be also visible on the service map and dependencies as well. Please check that other datastore functionalities also work as expected.
If you can provide snapshots of a trace and these other views I mentioned, that could be useful as well.

Looking forward for your feedback as an indication whether additional work is required at this point.

@spmason
Copy link
Author

spmason commented May 13, 2022

Thanks. Our Jedis 4 upgrade is actually dependant on a bigger refactoring of our Redis use that needs to go out first, so it'll be a little while before I'll be able to do more extensive testing of this. I'll keep you informed

@eyalkoren
Copy link
Contributor

What I did in #2626 is change the way we instrument Jedis for all versions, so that it is simpler and also more suitable for Jedis 4.
So actually, if you are using older Jedis (and Redis) versions across your services along with Elastic Java agent, then trying the provided snapshot on them and comparing with tracing produced by the existing agent, would provide an even better indication that this change is good 🙂

@eyalkoren
Copy link
Contributor

Version 1.31.0 has been released with Jedis 4.x support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-java community Issues and PRs created by the community triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants