Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 instrumentation does not contain s3 in destination.service.resource name #2849

Closed
AlexanderWert opened this issue Oct 17, 2022 · 2 comments · Fixed by #2947
Closed

S3 instrumentation does not contain s3 in destination.service.resource name #2849

AlexanderWert opened this issue Oct 17, 2022 · 2 comments · Fixed by #2947
Assignees
Milestone

Comments

@AlexanderWert
Copy link
Member

All backends should have a name pattern of type/name (where name is recommended but not mandatory).
The current S3 instrumentation sets the destination.service.recourse.name field to the bucket name (without the s3/ prefix).

The consequence is that in the dependencies view in the UI it's not clear at all what type of service it is:
image

Note: This potentially requires a spec change and changes in other agents as well.

@AlexanderWert
Copy link
Member Author

BTW, it seems we have the same problem with SQS:
image

@trentm
Copy link
Member

trentm commented Oct 17, 2022

@AlexanderWert I asked this somewhat recently (but mixed up with a bunch of other questions) here: elastic/apm#674 (comment)

  • Should context.destination.service.resource be changed to include an 's3/' prefix?
    Currently the S3 spec has service.target = { type: 's3', name: '$bucketNameIfAvailable' }. This means that following the usual inference of context.destination.service.resource from context.service.target we would expect "s3/$bucketName" (or "s3" if there is no bucket name, e.g. for the "ListBuckets" API call) rather than the currently specified "$bucketNameIfAvailable".

@SylvainJuge had a bit of a follow up to the second point there in this comment: elastic/apm#674 (comment)

FWIW, with the Node.js agent we have an "sqs/"-prefix for SQS span.context.destination.service.resource. It is just S3 that is the special case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants