Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transaction name for non-sampled transactions #597

Merged

Conversation

felixbarny
Copy link
Member

@felixbarny felixbarny commented Apr 17, 2019

fixes #581

@codecov-io
Copy link

Codecov Report

Merging #597 into master will increase coverage by 0.14%.
The diff coverage is 22.22%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #597      +/-   ##
============================================
+ Coverage     62.25%   62.39%   +0.14%     
  Complexity       68       68              
============================================
  Files           188      188              
  Lines          7092     7060      -32     
  Branches        818      814       -4     
============================================
- Hits           4415     4405      -10     
+ Misses         2408     2387      -21     
+ Partials        269      268       -1
Impacted Files Coverage Δ Complexity Δ
...va/co/elastic/apm/agent/impl/transaction/Span.java 66.66% <ø> (+2.89%) 0 <0> (ø) ⬇️
...lastic/apm/agent/impl/transaction/Transaction.java 88.23% <ø> (+16.8%) 0 <0> (ø) ⬇️
...astic/apm/agent/impl/transaction/AbstractSpan.java 81.25% <22.22%> (-9.98%) 0 <0> (ø)
...gent/servlet/wildfly/WildFlyLifecycleListener.java 85.71% <0%> (-14.29%) 0% <0%> (ø)
.../apm/agent/concurrent/ExecutorInstrumentation.java 45.45% <0%> (+4.71%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f51f253...53510f2. Read the comment docs.

@felixbarny felixbarny merged commit 1ca0be8 into elastic:master Apr 23, 2019
@felixbarny felixbarny deleted the fix-non-sampled-transaction-name branch April 23, 2019 08:42
@SylvainJuge SylvainJuge added bug Bugs and removed type: bug labels Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing transaction name randomly on Jersey API endpoints
4 participants