New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for Jenkins CI setup. #24
Comments
I'd love input on how to do this better. The reason why we just do it every time right now is because a change in the agent can break support for an old version of one of the modules we instrument. And since we don't control which versions of say mysql that users are running, we can't just only test against the latest version. Instead we have to also test that we still work as expected with old versions. But there might be a smarter way to run the tests, so I'm open to suggestions 😃 |
@watson How often did you break these in the past and how likely are they to break? Reason I'm asking because my suggestion would be to run them only after a merge into master if breaking it is pretty rare but allow a command like |
@ruflin Hard to say. It has happened before, but it's not that often. Your solution could work. I guess I just have to get comfortable with potentially broken code sneaking into master, but in many cases I'm able to know exactly when instrumented modules need to be tested. Maybe we could even narrow it down to say only test the |
Sounds like we could try this and see where it breaks? :-) |
@ruflin let's do that |
@simitt would you be able to take this on? |
I first have to figure out the current issues with the webhooks. As soon as the general setup is fixed I can take this over. |
Just thought I'd do a quick status update on our progress with the Jenkins integration: These tasks are all implemented:
These tasks are still not implemented:
|
thanks @watson. |
I'd say the slack notifications are pretty low priority anyway, so I'm fine with that 👍 |
Since we got the ability to trigger jenkins builds for tav tests, I'll go ahead and close this issue |
This is a Meta Issue to collect ideas and improvement suggestions for further Improvements regarding Jenkins setup.
The text was updated successfully, but these errors were encountered: