could not capture stack trace for span #588
Comments
|
Thanks for reporting. Can I get you to search through all your dependencies (and sub-dependencies etc) for where |
|
Thanks for the quick response. const orginal = Error.prepareStackTrace
const overwrites = []
Object.defineProperty(Error, 'prepareStackTrace', {
set: (v) => {
overwrites.push(v)
console.error()
console.error('prepareStackTrace set at')
console.trace()
console.error()
},
get() {
return overwrites[0] // igonre all but the first assignment of prepareStackTrace
}
})
const apm = require('elastic-apm-node').start()With all that instumentation and environment variable By using the defineProperty trick i prevent prepareStackTrace from being overwritten. Now that prepareStackTrace is set correctly however stackman failes and causes the app to exit. Do you have an idea if stackman works with webpack? |
|
The package type prepTrace = (error, structuredStackTrace) => void
type Wrapper = prepTrace & { impl?: prepTrace }
let prepareStackTraceImpl = undefined
Object.defineProperty(Error, 'prepareStackTrace', {
set: (v) => {
if (v.impl) {
prepareStackTraceImpl = v.impl
return
}
prepareStackTraceImpl = v
},
get() {
if (!prepareStackTraceImpl) {
return
}
const wrapper: Wrapper = (err, callsites) => {
// the following call is copied from error-callsites package
Object.defineProperty(err, '__error_callsites', {
enumerable: false,
configurable: true,
writable: false,
value: callsites
})
return wrapper.impl.call(Error, err, callsites)
}
wrapper.impl = prepareStackTraceImpl
return wrapper
}
})
const apm = require('elastic-apm-node').start()With that code i get the stacktraces in kibana apm: In the stack trace can even see the real original file name and type along with the correct line number. stackman prints out a bunch a of Do you have an idea why i don't see any surrounding lines for the stack taces? |
It should - or at least it shouldn't crash - worst case it should just give up on collecting the stack trace and your app should continue as normal. But you might have discovered a bug. I'll see if I can reproduce it. Do you happen to have a stack trace handy so I can see where it fails?
It's not body-parser or express that are overwriting The dept module uses After I read the source code of dept, it seems like it's doing it in a way that's not in conflict with stackman. I.e. it's only overwriting |
|
sorry for the delay - was on vacation |
|
I did not investigate further since we encountered #398 in production and disabled the capturing of stack traces altogether. (i'll post details on that issue) I consider this issue solved since i could get the capturing of stack traces to work by ensuring prepareStackTrace is not overwritten by any other package. Stackman failing to capture the surrounding lines is technically a different issue for which i'd open a separate issue in case in case #398 gets solved and the issue remains. Thanks for the quick support. |
This is likely not a bug - rather i am probbably missing something:
APM is working except that my spans don't have any stacktraces.
In my node app i get messages like this for every single span:
So far i stopped using
import 'source-map-support/register'to not alter prepareStackTrace as reccomended in https://discuss.elastic.co/t/node-agent-could-not-capture-stack-trace-for-span/130775. Doing this however did not help.My node app uses typescript and webpack.
node: v8.9.4
webpack: 3.11.0
typscript: 3.0.1 and emits es2018 code.
babel is not used and i boostrap via
const apm = require('elastic-apm-node').start()with env varsWebpack emits my server.js along with server.js.map and the server.js correctly references the source map like
//# sourceMappingURL=server.js.maplike it said it needs to in https://www.elastic.co/guide/en/apm/agent/nodejs/current/source-maps.html and i never had issues with source maps during debugging.Can you help me to get rid of the error messages and get the spans to work correctly?
The text was updated successfully, but these errors were encountered: