Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover service name automatically #68

Open
SergeyKleyman opened this issue Jun 30, 2020 · 4 comments
Open

Discover service name automatically #68

SergeyKleyman opened this issue Jun 30, 2020 · 4 comments
Labels
enhancement New feature or request from a real user This issue is from a real user (i.e., not an issue we found during internal testing) priority: medium triage: pass 1 umbrella

Comments

@SergeyKleyman
Copy link
Contributor

SergeyKleyman commented Jun 30, 2020

As step 1 we should define what is expected result for each use case (where use cases can be grouped by used web framework - WordPress, Laravel, etc.)

Consider when we can discover service name automatically:

  • Investigate if developers already provide this information to some frameworks (Laravel, etc.)
  • Investigate if we can extract service name from Apache/NGINX
  • Investigate if we can extract service name from application location at the file system
  • Investigate if there are other approaches
@philkra
Copy link
Contributor

philkra commented Jun 30, 2020

addendum: provide a manual override on the app level that trumps all previous investigations

@SergeyKleyman
Copy link
Contributor Author

@philkra By "on the app level" do you mean by using agent's API in addition to configuration (I've added #70 to follow up on configuration part)?

@science695
Copy link

When thinking about this, keep in mind that some people may run multiple services as virtualhosts on the same server, or different php-fpm pools, etc...

Possible sources of data: composer.json or other package managers

@SergeyKleyman
Copy link
Contributor Author

@science695 Great point. The challenge will be to find the application's composer.json file... Maybe we can instrument spl_autoload_register and get path to application's vendor directory when composer registers its autoload handler... It's going to be interesting :)

@SergeyKleyman SergeyKleyman added the enhancement New feature or request label Jun 30, 2020
@SergeyKleyman SergeyKleyman added from a real user This issue is from a real user (i.e., not an issue we found during internal testing) priority: medium umbrella triage: pass 1 labels Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request from a real user This issue is from a real user (i.e., not an issue we found during internal testing) priority: medium triage: pass 1 umbrella
Projects
None yet
Development

No branches or pull requests

3 participants