Doesn"t cut request body with size >= 10000 #1635
Conversation
last push to master has errors, if body size more than 10000, it writes 10000 message to elastic and call await self.app(scope, receive, wrapped_send) with same receive and invalid body, I separate receivers and now, if request has body more than 10000 -> it will send to elastic only 10000 and continue handle as normal request without cutting
|
💚 CLA has been signed |
github-actions
bot
added
agent-python
community
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
|
/test |
|
/test full |
|
Find strange bug in API related with apm agent is more easier than make a pull request... |
|
/test benchmark |
|
run elasticsearch-ci/docs |
* Fixes capture_body flag not being respected and improves performance of body reader. * Adds a test to ensure non-UTF-8 data is not triggering errors in ignored paths. * Apply encoding.long_field to starlette body Also update encoding.long_field to handle bytes * CHANGELOG Co-authored-by: Colton Myers <colton.myers@gmail.com> Co-authored-by: Colton Myers <colton@myers.fm>
mukhamux
changed the title
|
/test |
|
Sorry for the confusion, but only people with write access to the repo can trigger the tests. I'll take a look at this today. |
🌐 Coverage report
|
|
/test linters |
|
/test linters |
|
I opened a PR to add a CHANGELOG entry and fix the test: mukhamux#1 |
Add changelog and a test for elastic#1635
merged |
What does this pull request do?
b4edea3 has errors, if body size has more than 10000 bytes, it writes 10000 bytes message to elastic and call await self.app(scope, receive, wrapped_send) with same receive and invalid body,
Comment:
I separate receivers and now, if request has body more than 10000 bytes -> it will send to elastic only 10000 bytes and continue handle as normal request without cutting