Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels and deprecate tags on Intake API #1835

Closed
simitt opened this issue Jan 24, 2019 · 4 comments
Closed

Add labels and deprecate tags on Intake API #1835

simitt opened this issue Jan 24, 2019 · 4 comments
Labels

Comments

@simitt
Copy link
Contributor

simitt commented Jan 24, 2019

Follow up from #1826:

Change Intake API to allow for sending labels rather than tags:

Option (1):
deprecate current: { transaction: context: { tags: {}}}
introduce: { transaction: labels: {}, context: {}}

Option (2):
deprecate current: { transaction: context: { tags: {}}}
introduce: { transaction: context: { labels: {}}}

Option (3) - keep what we have:
{ transaction: context: { tags: {}}}

The format would be the same for errors and spans.
@elastic/apm-agent-devs please vote on what you'd prefer

@beniwohli
Copy link
Contributor

I vote for Option 1, tags in the context always felt a bit awkward

@felixbarny
Copy link
Member

I also vote on 1 as we are planning to remove context from the intake api anyway now that there is no context in ES documents as of 7.0 (#411).

@graphaelli
Copy link
Member

closing for now, will reopen if we decide to tackle this for 8.0

@simitt
Copy link
Contributor Author

simitt commented Aug 27, 2019

When we implement this we should probably deprecate tags before removing them completely (BC), to ensure a smooth upgrade path with the agents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants