Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The init script should use the Chef embedded Ruby? #215

Closed
paulczar opened this issue May 27, 2014 · 5 comments
Closed

The init script should use the Chef embedded Ruby? #215

paulczar opened this issue May 27, 2014 · 5 comments
Labels
Bug Something isn't working

Comments

@paulczar
Copy link

/etc/init.d/elasticsearch: line 111: ruby: command not found

not cool! we should use the chef embedded ruby for this, or find a way to do it in shell.
@karmi karmi changed the title init script runs a ruby command ... use chef embedded ruby ? The init script should use the Chef embedded Ruby? May 28, 2014
@karmi
Copy link
Contributor

karmi commented May 28, 2014

That's a good point, though not entirely sure we should "hijack" the Chef embedded Ruby like this. This is a leftover from days when Chef didn't come with it's own Ruby and was installed from Rubygems.

I think a cleaner solution might be to short-circuit the "verbose" service status when Ruby is not available on the system?

@paulczar
Copy link
Author

yeah I would be happy with that.

@karmi karmi added the bug label May 28, 2014
martinb3 added a commit to martinb3-cookbooks/cookbook-elasticsearch that referenced this issue Aug 25, 2014
@martinb3
Ensure a valid ruby exists before using it
090dd63 
If `command -v ruby` doesn't return a valid ruby binary, don't use the JSON parsing parts of the init script that depend on ruby. Also check for the validity of `-rubygems` as a ruby argument, as this works in ruby before 1.9, but after, it's invalid.

Fixes sous-chefs#215.
@martinb3 martinb3 mentioned this issue Aug 25, 2014
Closed
martinb3 added a commit to martinb3-cookbooks/cookbook-elasticsearch that referenced this issue Oct 10, 2014
@martinb3
Ensure a valid ruby exists before using it
bb3d4c1 
If `command -v ruby` doesn't return a valid ruby binary, don't use the JSON parsing parts of the init script that depend on ruby. Also check for the validity of `-rubygems` as a ruby argument, as this works in ruby before 1.9, but after, it's invalid.

Fixes sous-chefs#215.
martinb3 added a commit to martinb3-cookbooks/cookbook-elasticsearch that referenced this issue Oct 17, 2014
@martinb3
Ensure a valid ruby exists before using it
fb06a7a 
If `command -v ruby` doesn't return a valid ruby binary, don't use the JSON parsing parts of the init script that depend on ruby. Also check for the validity of `-rubygems` as a ruby argument, as this works in ruby before 1.9, but after, it's invalid.

Fixes sous-chefs#215.
@spuder
Copy link
Contributor

spuder commented Apr 14, 2015

+1 Is there an ETA on the release that includes this?

@karmi
Copy link
Contributor

karmi commented Apr 16, 2015

@spuder I haven't been able to find some time for this, and we're focused on the next branch now with @martinb3 -- I can see Martin fixed this in martinb3-cookbooks/cookbook-elasticsearch@fb06a7a, I'll try to merge and release it.

@karmi
Copy link
Contributor

karmi commented Apr 16, 2015

Sorrz for missing this for so long, closed in f7fb420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure a valid ruby exists before using it martinb3-cookbooks/cookbook-elasticsearch
3 participants
@karmi @spuder @paulczar