Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin installation does not have upgrade ability #264

Closed
cywjackson opened this issue Dec 17, 2014 · 5 comments

Comments

Projects
None yet
3 participants
@cywjackson
Copy link

commented Dec 17, 2014

      not_if do
        Dir.entries("#{node.elasticsearch[:dir]}/elasticsearch-#{node.elasticsearch[:version]}/plugins/").any? do |plugin|
          next if plugin =~ /^\./
          name.include? plugin
        end rescue false
      end 

From above, even when i have a new version of a plugin, the installation would still fail as it would detect the plugin has already been installed (with a diff version)

http://stackoverflow.com/questions/19997559/update-of-elasticsearch-plugin <-- seems suggest you can't install another version (without removing the old one)

so what should be the logic here?
if not installed, install it;
if installed with a prev version, remove and install;
if installed with the same version as define in attribute, do nothing?

@martinb3 martinb3 added the bug label Jul 7, 2015

@martinb3 martinb3 modified the milestones: 1.1.x release, 1.0.x bugfix release Jul 16, 2015

@martinb3 martinb3 added enhancement and removed bug labels Jul 17, 2015

@martinb3

This comment has been minimized.

Copy link
Contributor

commented Oct 16, 2015

@cywjackson Do you know how to determine the version of an existing plugin? As far as I can tell, there's no way to figure this out based on a copy of it. The only check we could do is compatible lucene version. /CC #330

@martinb3 martinb3 removed this from the 1.1.0 release milestone Oct 16, 2015

@martinb3

This comment has been minimized.

Copy link
Contributor

commented Oct 16, 2015

Additionally, as far as I can tell, there's actually no way using the commandline tools to safely upgrade the plugin either. The plugin command only does --remove and --install.

martinb3 added a commit that referenced this issue Oct 16, 2015

Add remove action for plugin
Per #264, add remove action. We still have no way of upgrading.
@martinb3

This comment has been minimized.

Copy link
Contributor

commented Oct 16, 2015

I'm going to close this, based on that. Let us know if you find anything differently than what I've said here, and we'll figure out how to translate the procedure into chef :)

@adagios

This comment has been minimized.

Copy link

commented Jul 27, 2016

Hi @martinb3,

I've stumbled on this issue and there is a way to know the versions of the installed plugins:

curl localhost:9200/_cat/plugins?v\&pretty
name         component       version        type url
Ghost Dancer delete-by-query 2.3.4          j
@martinb3

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2016

@adagios Hello! Unfortunately, we can't assume Elasticsearch is running or that what's loaded into memory reflects what is currently on disk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.