Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT: Document the process for submitting PRs #270

Closed
martinb3 opened this issue Jan 2, 2015 · 0 comments
Closed

NEXT: Document the process for submitting PRs #270

martinb3 opened this issue Jan 2, 2015 · 0 comments

Comments

@martinb3
Copy link
Contributor

martinb3 commented Jan 2, 2015

Per @karmi's email, it should be:

  • Create a branch directly in this repo or a fork (if you don't have push access), something like karmi/install_from_deb
  • Create an issue/open a PR
  • Close (and reference) issues by the Closes #XXX / Fixes #XXX notation in the commit message
  • Keep pushing commits to the initial branch
  • When everything is ready for merge, clean up the branch (rebase with next to synchronize, squash, edit commits, etc) and merge it into next (or master, when the time comes to move over to the next branch permanently)
  • When it's couple of commits which are to be considered a logical whole, merge it with --no-ff switch, so it's indicated in the Git history
  • Do not use the "merge button", since it doesn't do a fast-forward merge (see previous item)
@karmi karmi added the next label Jan 4, 2015
@martinb3 martinb3 added this to the 1.0.0 release to Supermarket milestone Jul 16, 2015
martinb3 added a commit that referenced this issue Jul 16, 2015
Add contribution guidelines discussed in email and documented in #270. Fixes #270.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants