Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy recipe has hardcoded localhost which fails if elasticsearch is not bound to that IP #85

Closed
tomdz opened this issue Apr 20, 2013 · 2 comments

Comments

@tomdz
Copy link

tomdz commented Apr 20, 2013

I'm using node.elasticsearch[:custom_config][:network.host] to have Elasticsearch bind to a specific IP (which is not 127.0.0.1). This works great, but the proxy recipe fails because it has localhost hardcoded (https://github.com/elasticsearch/cookbook-elasticsearch/blob/master/templates/default/elasticsearch_proxy.conf.erb#L26, https://github.com/elasticsearch/cookbook-elasticsearch/blob/master/templates/default/elasticsearch_proxy.conf.erb#L50). Instead it should use

<%= node.elasticsearch[:custom_config][:network.host] ||
    node.elasticsearch[:custom_config][:network.bind_host] ||
    'localhost' %>

(or something like that).

@karmi
Copy link
Contributor

karmi commented May 9, 2013

Hey, understood.

First, you can just set node.network.host, you shouldn't be forced to use the custom_config namespace.

I'll test the suggestion in Vagrant and verify it.

@karmi karmi closed this as completed in 07adcf5 May 9, 2013
@karmi
Copy link
Contributor

karmi commented May 9, 2013

Thanks!, implemented and verified. Please check out if this works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants