New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First pass at framework with testing, rake, etc #249
Conversation
martinb3
commented
Oct 17, 2014
- Due to Foodcritic and how Supermarket renders README.md, rename README.markdown to README.md
- Add some default files for .gitignore, .rubocop.yml, .kitchen.yml, etc
- Added a default recipe to install curl and create a dummy chef resource, just as an example to start with
- Add chefspec and test-kitchen/serverspec default test suites that just test the current default recipe
- Add test fixtures like a wrapper cookbook to test how downstream cookbooks might use this one
- Add lengthy documentation on testing, how it works in this cookbook, etc
- Due to Foodcritic and how Supermarket renders README.md, rename README.markdown to README.md - Add some default files for .gitignore, .rubocop.yml, .kitchen.yml, etc - Added a default recipe to install curl and create a dummy chef resource, just as an example to start with - Add chefspec and test-kitchen/serverspec default test suites that just test the current default recipe - Add test fixtures like a wrapper cookbook to test how downstream cookbooks might use this one - Add lengthy documentation on testing, how it works in this cookbook, etc
This looks promising. Also glad that we don't depend on build-essential/ark. Should we get this merged and start from there? |
First pass at framework with testing, rake, etc
Ah, about to merge this... you beat me to it, @bai :) |
First pass at framework with testing infrastructure, Rake tasks, etc - Due to Foodcritic and how Supermarket renders README.md, rename README.markdown to README.md - Add some default files for .gitignore, .rubocop.yml, .kitchen.yml, etc - Added a default recipe to install curl and create a dummy chef resource, just as an example to start with - Add chefspec and test-kitchen/serverspec default test suites that just test the current default recipe - Add test fixtures like a wrapper cookbook to test how downstream cookbooks might use this one - Add lengthy documentation on testing, how it works in this cookbook, etc Closes #249
@martinb3 @bai @vhyza Also, a question -- can we close (and reference) issues by the So, ideally, the process would be:
Does it sound OK? |
@karmi that'd be fine with me. I normally do tag the commits with the PRs... Not sure why I didn't here :-) |
Actually, let's put a CONTRIBUTING.md in the repo and document the workflow @karmi suggests, along with standard stuff like linking commit messages and pull requests and issues, and using 'closes' / 'fixes'. |