Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds field data values #314

Closed
wants to merge 3 commits into from
Closed

Adds field data values #314

wants to merge 3 commits into from

Conversation

spuder
Copy link
Contributor

@spuder spuder commented Apr 24, 2015

@spuder
Copy link
Contributor Author

spuder commented Apr 24, 2015

I'm pretty new to chef, so I'm not positive this is the right way to add values to the elasticsearch.yaml file. Feedback welcome.

Removes 'indices.fielddata.cache.expire' because experimental
Adds other breaker configurations.
@spuder
Copy link
Contributor Author

spuder commented Apr 28, 2015

Is there any update on this merge request?

@karmi
Copy link
Contributor

karmi commented May 1, 2015

@spuder Sorry, tied with many other things. So, first of all, any key:value pair set in Chef should be automatically inserted into the template, as described in: https://github.com/spuder/cookbook-elasticsearch/blob/patch-1/templates/default/elasticsearch.yml.erb#L9-L15 Does it work for you? Also, we're working on a refactoring of the cookbook (see next branch), so more focused there...

@spuder
Copy link
Contributor Author

spuder commented May 1, 2015

Thanks,

I'm finding that this doesn't work in a wrapper cookbook. This is the correct syntax is it not?

attributes/customize.rb

default[:elasticsearch][:custom_config] = {
  'indices.breaker.fielddata.limit' => '75%',
  'indices.fielddata.cache.size' => '65%'
}

http://stackoverflow.com/questions/29991737/how-do-you-set-node-configurations-in-chef

@karmi
Copy link
Contributor

karmi commented May 1, 2015

Yeah, that should work!, but haven't tried it in a wrapper cookbook...

@spuder
Copy link
Contributor Author

spuder commented May 1, 2015

This is a good work around, but it looks like there are 2 elasticsearch.yml files. Chef manages the second one. Took me a while to figure this out.

/usr/local/elasticsearch/conf/elasticsearch.yml
/usr/local/etc/elasticsearch/elasticsearch.yml

Now that I have this workaround, the need for this pull request is significantly reduced. I still think it might be a good value to have in the template since it looks like a common config change.

@martinb3 martinb3 closed this Jul 2, 2015
@spuder spuder deleted the patch-1 branch July 3, 2015 01:56
@martinb3
Copy link
Contributor

martinb3 commented Jul 3, 2015

Hi there -- we've promoted a new, fully re-written branch to master on this cookbook. We've discovered Github actually automatically closes all PRs when the branch they're made onto is moved. Please re-open if your PR still applies to the re-written cookbook. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants