Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for new logstash-filter-elastic_integration plugin are not being picked up for LSR #105

Closed
karenzone opened this issue Jan 25, 2024 · 6 comments
Assignees

Comments

@karenzone
Copy link
Contributor

karenzone commented Jan 25, 2024

Related: elastic/logstash-docs#1598

We recently added support for plugins outside of the logstash-plugins GitHub org with #103.

Versioned Plugin Reference (VPR)

  • The VPR build is picking up changes as expected. ✅
    Example: auto generated update picked up filter-elastic_integration v0.1.4

Logstash Reference (LSR)

  • The filter-elastic_integration content that is currently published was added manually (PR #1579) with the plan to have it update programmatically for future version bumps.
  • The plugin has been added to rakelib/plugins-metadata.json (PR #15692)
  • I generated plugin docs for main after filter-elastic_integration v9.1.4 came through for the VPR.
    The v9.1.4 update didn't get picked up for the LSR. ❌

Published pages

Screen Shot 2024-01-25 at 5 51 38 PM

@mashhurs, thanks again for your great work on the docs tooling. It seems that we have one more kink to work out before this works seamlessly.

@karenzone karenzone self-assigned this Jan 25, 2024
@mashhurs
Copy link
Contributor

mashhurs commented Jan 26, 2024

Hm, interesting. ./gradlew generatePluginsVersion somehow didn't include elastic_integration plugin in plugins_version_docs.json. I will investigate and fix this, assigning myself.

Thanks for catching this up!

@mashhurs mashhurs self-assigned this Jan 26, 2024
@karenzone
Copy link
Contributor Author

Fantastic! Thanks for your help with this, @mashhurs.

@mashhurs
Copy link
Contributor

mashhurs commented Mar 7, 2024

@karenzone this was covered when non-OSS feature was introduced. Sorry that I forgot to update here 🤦
I have just run the workflow to double check and it is here: I have https://github.com/elastic/logstash-docs/pull/1613/files#diff-d795e5afb754865b186622bfd833c211c013d0a49f7b8d050e06915dab87ffa3

@karenzone
Copy link
Contributor Author

karenzone commented Mar 7, 2024

Awesome! Thanks for fixing this.
Do you have a PR number we can link to this issue for future reference?

@mashhurs
Copy link
Contributor

mashhurs commented Mar 7, 2024

Awesome! Thanks for fixing this. Do you have a PR number we can link to this issue for future reference?

I'm going to delete my previous comment to avoid confusion. :-)

Here it is: elastic/logstash#15769

@karenzone
Copy link
Contributor Author

Fixed with merge of elastic/logstash#15769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants