Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Logback 1.1 #87

Closed
felixbarny opened this issue Aug 6, 2020 · 0 comments · Fixed by #88
Closed

Support for Logback 1.1 #87

felixbarny opened this issue Aug 6, 2020 · 0 comments · Fixed by #88

Comments

@felixbarny
Copy link
Member

Currently, we require Logback 1.2 as the Encoder interface has changed.

https://github.com/qos-ch/logback/blob/v_1.1.0/logback-core/src/main/java/ch/qos/logback/core/encoder/Encoder.java
https://github.com/qos-ch/logback/blob/v_1.2.0/logback-core/src/main/java/ch/qos/logback/core/encoder/Encoder.java

It should be possible to support older versions by implementing the method the 1.1 versions defied, without annotating them with @Override.

@felixbarny felixbarny changed the title Support for Logback 1.2 Support for Logback 1.1 Aug 10, 2020
@zube zube bot removed the [zube]: Done label Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants