Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discuss] ignore_above on flattened fields #2247

Open
ebeahan opened this issue Aug 4, 2023 · 0 comments
Open

[Discuss] ignore_above on flattened fields #2247

ebeahan opened this issue Aug 4, 2023 · 0 comments
Labels

Comments

@ebeahan
Copy link
Member

ebeahan commented Aug 4, 2023

Question for discussion: Should ECS set ignore_above by default on flattened fields?

Context

Pointed out in #2237, ECS doesn't yet support setting ignore_above explicitly set on flattened fields (fix incoming).

As a convention, the artifacts generated by ECS set the ignore_above parameter on all keyword fields. Setting ignore_above avoids exceptions due to Lucene size limit for a single term and avoids unnecessarily indexing longer string values.

Other considerations

  • If ECS did set ignore_above on flattened type fields, should ECS use the existing convention of ignore_above: 1024?
  • Implications
    • If set, any fields with character counter > ignore_above will no longer be indexed and only appear in _source.
    • On the other hand, any flattened field values larger than the Lucene limit of 32766 bytes with cause an exception. Unsure if this affects the entire flattened field or just the specific leaf field that's oversized (but could be easily tested).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant