Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User.hash vs. new hash.* fields #483

Open
vbohata opened this issue Jun 11, 2019 · 3 comments
Open

User.hash vs. new hash.* fields #483

vbohata opened this issue Jun 11, 2019 · 3 comments
Labels
ready Issues we'd like to address in the future.

Comments

@vbohata
Copy link

vbohata commented Jun 11, 2019

#426 added hash.* fields but "user" already contains hash. So user.hash should become user.hash.*.

@andrewthad
Copy link
Contributor

I agree with this. Would a PR for this be accepted?

@webmat
Copy link
Contributor

webmat commented Aug 26, 2019

It's a good point, thanks for offering to submit a PR.

Since this would be a breaking change, I suggest we keep that discussion open and consider it for ECS 2.0 / Elastic Stack 8.0.

@webmat webmat added the 2.0.0 label Aug 26, 2019
@ebeahan ebeahan added ready Issues we'd like to address in the future. and removed 2.0.0 labels Apr 15, 2021
@ebeahan
Copy link
Member

ebeahan commented Dec 20, 2021

Since this issue was opened, the hash.* field set has grown and guidance added that entity-specific hashes should be placed in their related fieldset (for example, ja3 is underneath tls.*).

I can see value to having the various hash.* types to hash the value of the user.*. However, I also see value in how the current user.hash field is described: "Unique user hash to correlate information for a user in anonymized form.".

Having a single field remain that holds the "anonymised" value of the user.name or user.id seems useful. Any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Issues we'd like to address in the future.
Projects
None yet
Development

No branches or pull requests

4 participants