Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests #297

Merged
merged 5 commits into from Nov 16, 2020
Merged

Refactor tests #297

merged 5 commits into from Nov 16, 2020

Conversation

V1NAY8
Copy link
Contributor

@V1NAY8 V1NAY8 commented Oct 26, 2020 •
edited

Changes made are:

  • Refactored eland/tests/* to test_eland/* and imports used in tests.
  • Updated noxfile.py
  • Added code snippets to contributing.rst
  • All tests (Including tests, doctests) were run and successful

@sethmlarson Please review, Happy to make any changes required 馃槃

@elasticmachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@V1NAY8 V1NAY8 force-pushed the refactor-tests branch 2 times, most recently from c1c77f5 to 340666e Compare October 30, 2020 10:41
@V1NAY8 V1NAY8 changed the title Refactor tests and update contributing docs Refactor tests Oct 30, 2020
@V1NAY8 V1NAY8 mentioned this pull request Oct 30, 2020
Merged
@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Nov 10, 2020 •
edited

@sethmlarson . Can you please review this and merge into master? because i was writing tets for mode and wanted to see code coverage, it was messy
Example of our existing which even includes coverage for tests as well.

  • I have also added the term-missing paramter just to see at what lines the coverage is missing.

sethmlarson
sethmlarson suggested changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Instead of test_eland/ let's do tests/..., also leave all the folder structure under tests/ the same (ie don't rename tests/dataframe to tests/test_dataframe)

@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Nov 10, 2020

Yep refactored them

@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Nov 12, 2020 •
edited

@sethmlarson Right now builds are failing in master. The pytest issue looks similar to this https://stackoverflow.com/questions/10253826/path-issue-with-pytest-importerror-no-module-named-yadayadayada

So, made changes,
this has to be merged before my other PR's.
Please ask jenkins to test this.

sethmlarson
sethmlarson approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will run CI to make sure everything is good.

@sethmlarson
Copy link
Contributor

jenkins test this please

@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Nov 16, 2020 •
edited

@sethmlarson , can you re-ask jenkins to test this please. I made a small path mistake.

@sethmlarson
Copy link
Contributor

jenkins test this please

@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Nov 16, 2020

Not sure why it failed for 7.6,7.7. Looks like ES issue.

@sethmlarson
Copy link
Contributor

It's an unrelated failure due to Elasticsearch changing the routes for ML trained models. I'll fix the issue.

@sethmlarson
Copy link
Contributor

It looks like there's a merge conflict after I merged the progress bar PR, could you fix that up?

@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Nov 16, 2020

Yes on it

@sethmlarson
Copy link
Contributor

jenkins test this please

@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Nov 16, 2020

Good bye merge conflicts :) Done!

@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Nov 16, 2020

Finally, this looks good

sethmlarson
sethmlarson approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethmlarson sethmlarson merged commit 473db45 into elastic:master Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@V1NAY8 @elasticmachine @sethmlarson