Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need to define host in hints autodiscovery by using proper default values #1453

Closed
2 tasks done
ChrsMark opened this issue Oct 10, 2022 · 1 comment · Fixed by #3575
Closed
2 tasks done
Assignees
Labels
cloudnative-observability Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team

Comments

@ChrsMark
Copy link
Member

ChrsMark commented Oct 10, 2022

Describe the enhancement:
At the moment users need to specify the host to collect metrics from a Pod in hints based autodiscovery.
We can make the host setting optional and use as the default the most common value which is the Pod's IP along with the proper container's port. At the moment the user needs to provide sth like ${kubernetes.pod.ip}:3601. With this enhancement, the user would just need to define the package in hints and the defaults should be able to cover in the general case. This enhancement was identified after working on elastic/observability-docs#2198.

Tasks

  1. Team:Cloudnative-Monitoring Team:Elastic-Agent backport-skip enhancement
    constanca-m
  2. backport-skip
    constanca-m
@ChrsMark ChrsMark added Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team cloudnative-observability labels Oct 10, 2022
@ChrsMark ChrsMark self-assigned this Feb 2, 2023
@mlunadia
Copy link

mlunadia commented Feb 7, 2023

@ChrsMark let's give this a more specific title. Improve
https://github.com/elastic/observability-dev/blob/461a217dc91cb6e099fb7f64b040e8f25bb1ec1c/docs/how-we-work/writing-content-cheatsheet.md#titles-checklist

@ChrsMark ChrsMark changed the title Improve hints based autodiscovery defaults Remove the need to define host in hints autodiscovery by using proper default values Feb 8, 2023
@constanca-m constanca-m assigned constanca-m and unassigned ChrsMark Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cloudnative-observability Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants