Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heatmap] visualizations don't adjust color values for dark mode #1335

Closed
2 tasks done
ghudgins opened this issue Aug 24, 2021 · 2 comments · Fixed by #1406
Closed
2 tasks done

[Heatmap] visualizations don't adjust color values for dark mode #1335

ghudgins opened this issue Aug 24, 2021 · 2 comments · Fixed by #1406
Assignees
@nickofthyme
Labels
bug Something isn't working :heatmap Heatmap/Swimlane chart related issue Impact:High kibana cross issue Has a Kibana issue counterpart
Projects
Heatmap Beta Heatmap

Comments

@ghudgins
Copy link

Describe the bug
Heatmap doesn't adapt to the currently running Kibana theme

To Reproduce

  • Enable dark mode in Kibana
  • Visit ML anomaly viewer

Expected: Heatmap adapts to theme
Actual: Heatmap does not adapt to theme

Note: Lens works around this by explicitly setting background color

image

Version (please complete the following information):

  • OS: OSX
  • Browser: chromium edge 92
  • Elastic Charts: version @ Kibana 7.15 BC1

Kibana Cross Issues
elastic/kibana#97636

Checklist

Delete any items that are not applicable to this issue.

  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@ghudgins ghudgins added bug Something isn't working kibana cross issue Has a Kibana issue counterpart :heatmap Heatmap/Swimlane chart related issue labels Aug 24, 2021
@ghudgins ghudgins added this to 2️⃣ MUST HAVE for GA (8.1) in Heatmap Beta Aug 24, 2021
@darnautov
Copy link
Contributor

I found out the actual cause. I think this regression was introduced recently. For some reason, yAxisLabel.fill and xAxisLabel.fill props are ignored

@darnautov darnautov mentioned this issue Aug 25, 2021
Merged
1 task
@markov00 markov00 moved this from 2️⃣ MUST HAVE for GA (8.1) to 1️⃣ MUST HAVE for experimental in Heatmap Beta Aug 26, 2021
@nickofthyme nickofthyme moved this from 1️⃣ MUST HAVE for exp (8.0) to In progress in Heatmap Beta Aug 30, 2021
@nickofthyme
Copy link
Collaborator

Lowering impact due to elastic/kibana#110515 as a workaround for 7.15. This workaround does not close this issue nor the kibana linked issue.

This was referenced Aug 30, 2021
Merged
Merged
@nickofthyme nickofthyme mentioned this issue Sep 23, 2021
Merged
9 tasks
@markov00 markov00 added this to 2️⃣ MUST HAVE for GA (8.1) in Heatmap Nov 18, 2021
@markov00 markov00 moved this from 2️⃣ MUST HAVE for (8.1) to In progress in Heatmap Nov 18, 2021
Heatmap automation moved this from In progress to Done Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickofthyme nickofthyme

Labels
bug Something isn't working :heatmap Heatmap/Swimlane chart related issue Impact:High kibana cross issue Has a Kibana issue counterpart
Projects
No open projects
Heatmap
Done
Heatmap Beta
  
In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(heatmap): dark mode with theme controls nickofthyme/elastic-charts
3 participants
@darnautov @ghudgins @nickofthyme