Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cartesian] improve gridlines z-index #2121

Open
Tracked by #1902 ...
markov00 opened this issue Aug 2, 2023 · 0 comments
Open
Tracked by #1902 ...

[cartesian] improve gridlines z-index #2121

markov00 opened this issue Aug 2, 2023 · 0 comments
Labels
:axis Axis related issue enhancement New feature or request :xy Bar/Line/Area chart related

Comments

@markov00
Copy link
Member

markov00 commented Aug 2, 2023

If different grays are used on axis line and grid lines, there can be overlaps that don't look nice as shown in the following example:
Screenshot 2023-08-02 at 14 10 49

There could be a few possible solutions to this:

  • allow using only one color for grid/axis lines
  • render always the axis after rendering the grid but this will not solve the problem if the grid lines have different shades.

When different shades are used, then probably we need to sort the rendering order by color or by importance and render first light colors and then darker colors or more important elements ontop of less important elements.

Here is a demo PR to prove the point #2122

@markov00 markov00 changed the title gridlines z-index vs cursor z-index (don't render gridline above the cursor line) [cartesian] Gridlines and cursor z-index Aug 2, 2023
@markov00 markov00 changed the title [cartesian] Gridlines and cursor z-index [cartesian] Gridlines z-index by color Aug 2, 2023
@markov00 markov00 added enhancement New feature or request :axis Axis related issue :xy Bar/Line/Area chart related labels Aug 2, 2023
@markov00 markov00 changed the title [cartesian] Gridlines z-index by color [cartesian] improve gridlines z-index Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:axis Axis related issue enhancement New feature or request :xy Bar/Line/Area chart related
Projects
None yet
Development

No branches or pull requests

1 participant