fix(metric): move body to datum #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickofthyme
pushed a commit
that referenced
this pull request
Feb 13, 2024
# [64.0.0](v63.1.0...v64.0.0) (2024-02-13) ### Bug Fixes * **deps:** update dependency @elastic/eui to ^93.1.0 ([#2332](#2332)) ([855e357](855e357)) * **deps:** update dependency @elastic/eui to v93 ([#2324](#2324)) ([ce19379](ce19379)) * **deps:** update dependency @playwright/test to ^1.41.2 ([#2330](#2330)) ([1f8c638](1f8c638)) * **metric:** move `MetricSpec.body` to `MetricBase` ([#2336](#2336)) ([3390e25](3390e25)) * use passed size in pixel without waiting for resizeObserver ([#2270](#2270)) ([f9c11fc](f9c11fc)) ### chore * **bullet:** bullet improvements, bug fixes and renaming ([#2319](#2319)) ([34fd38b](34fd38b)) ### BREAKING CHANGES * **metric:** Moves `MetricSpec.body` to `MetricDatum.body`/`MetricBase.body` * **bullet:** Rename `BulletGraph` to `Bullet` and `ColorBandSimpleConfig.classes` to `steps`
1 task
shahzad31
added a commit
to elastic/kibana
that referenced
this pull request
Mar 4, 2024
## Summary Since [Elastic/charts](elastic/elastic-charts#2336) now supports body content in metric chart, removing the custom implementation in favor !! ### Testing - [ ] Make sure badges works as expected in Card view <img width="1728" alt="image" src="https://github.com/elastic/kibana/assets/3505601/cda11ded-0297-4636-bc7d-26d9e76eb8d1"> --------- Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When adding support for a
bodycomponent in theMetricgap area in #2303, we put it on the top-levelMetric. This inhibites consumers from having a differentbodyperMetricDatumin a grid. This PR moves thebodyoption to theMetricDatum.Issues
#2182
Checklist
:xy,:partition)closes #123,fixes #123)packages/charts/src/index.ts