feat(theme): move annotation default styles to Theme
#2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moves default styles to theme under lineAnnotation & rectAnnotation - deprecated standalone default style exports - updates default annotation colors per theme
nickofthyme
added
:annotation
nickofthyme
changed the title
Theme
|
buildkite update screenshots |
markov00
approved these changes
Mar 13, 2024
This comment was marked as resolved.
This comment was marked as resolved.
|
buildkite update screenshots |
nickofthyme
pushed a commit
that referenced
this pull request
Mar 13, 2024
# [64.1.0](v64.0.2...v64.1.0) (2024-03-13) ### Features * **theme:** move annotation default styles to `Theme` ([#2357](#2357)) ([fe19ae2](fe19ae2))
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As part of the work to reclaim the charts theme from eui we need to adopt the line annotation styles defined here. These styles are dependent on the theme type so to adopt this in
@elastic/chartswe addedlineAnnotation&rectAnnotationto theTheme.The new defaults are used from the theme and ignore
DEFAULT_ANNOTATION_LINE_STYLEandDEFAULT_ANNOTATION_RECT_STYLE. To use these old default please use the desired legacy theme export.Details
lineAnnotation&rectAnnotationDEFAULT_ANNOTATION_LINE_STYLEandDEFAULT_ANNOTATION_RECT_STYLE)Issues
related to #2069
Checklist
:xy,:partition):interactions,:axis)closes #123,fixes #123)packages/charts/src/index.tslightanddarkthemes