Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Legend] Show data series icon for filters only at hover #2444

Open
gvnmagni opened this issue May 30, 2024 · 3 comments
Open

[Legend] Show data series icon for filters only at hover #2444

gvnmagni opened this issue May 30, 2024 · 3 comments
Labels
:legend Legend related issue

Comments

@gvnmagni
Copy link

I would love to consider if it is possible to hide that icon on the right side of each data series and to show it only at mouse-hover, this way we would clean up the legend from unnecessary and repetitive elements

Current state:
Screenshot 2024-05-30 at 11 53 39

Suggested state:
Screenshot 2024-05-30 at 11 58 36

@1Copenut any accessibility issues that we might encounter?

@gvnmagni gvnmagni added the :legend Legend related issue label May 30, 2024
@nickofthyme
Copy link
Collaborator

Eui currently does something similar to this in the EuiDataGrid.

Zight Recording 2024-06-03 at 10 40 56 AM

@1Copenut
Copy link

1Copenut commented Jun 3, 2024

I'm okay making these Action menus appear on ::hover as long as they also appear on ::focus. Practically speaking it means hiding them visually until hovered or focused, then showing. I'm okay going this direction as long as we have a chance to test for keyboard and screen reader usability before the change is merged, or quickly after merge in case we need to roll back.

EuiDataGrid has this behavior, but also allows for users to press Enter to open the [ ... ] menu. That's a standard data grid interaction pattern that presents similarly for mouse interaction but is ever so nuanced for keyboard interaction.

@gvnmagni
Copy link
Author

gvnmagni commented Jun 4, 2024

Thank you @1Copenut!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:legend Legend related issue
Projects
None yet
Development

No branches or pull requests

3 participants